Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend changes to wasmer init #3432

Merged
merged 27 commits into from
Dec 21, 2022
Merged

Amend changes to wasmer init #3432

merged 27 commits into from
Dec 21, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Dec 16, 2022

This reverts commit 250ebff.

This is a continuation of #3324 (to keep the git history in a proper format), so we can address review comments that came in after the PR was merged.

@fschutt fschutt requested a review from syrusakbary as a code owner December 16, 2022 22:45
syrusakbary
syrusakbary reviewed Dec 16, 2022
View reviewed changes
lib/cli/Cargo.toml Outdated Show resolved Hide resolved
Michael-F-Bryan
Michael-F-Bryan suggested changes Dec 20, 2022
View reviewed changes
lib/cli/src/commands/init.rs Show resolved Hide resolved
lib/cli/src/commands/init.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/init.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/init.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/init.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/publish.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/publish.rs Show resolved Hide resolved
lib/cli/src/commands/publish.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/publish.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/publish.rs Outdated Show resolved Hide resolved
@fschutt fschutt enabled auto-merge December 21, 2022 08:31
@fschutt
Copy link
Contributor Author

fschutt commented Dec 21, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 21, 2022

Configuration problem:
bors.toml: not found

@fschutt fschutt merged commit d5adde8 into master Dec 21, 2022
@fschutt fschutt deleted the init-2 branch December 21, 2022 15:19
This was referenced Jan 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke left review comments

@syrusakbary syrusakbary syrusakbary left review comments

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fschutt @syrusakbary @theduke @Michael-F-Bryan